fix(system): Update TargetEnvVar instead of PATH #6580
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functions
Add-Path,Remove-Pathadmit an argument-TargetEnvVarwhich would update the correct profile or system environment variable, but would always act onPATHin the current session.I simply replaced
$env:PATHwithGet/Set-Content "env:$TargetEnvVar"to fix this. I have also updated the message 'Adding (...) to your path', so there will be a visible change to 'Adding (...) to your PATH'.(I suppose this doesn't merit an entry in the CHANGELOG... does it?)
Motivation and Context
Closes #6579.
How Has This Been Tested?
I have checked the functions manually in the terminal, including with non-existing variables (hence the
-ErrorAction Ignore).Checklist:
developbranch.