[WIP] Multi governor client #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
davidlaprade
commented
Apr 4, 2025
src/FlexVotingBase.sol
Outdated
| /// | ||
| /// To get the vote weight on a governor for a user at timepoint t use: | ||
| /// voteWeightCheckpoints[governor][user].upperLookup(t) | ||
| mapping(IFractionalGovernor => mapping(address => Checkpoints.Trace208)) internal |
There was a problem hiding this comment.
Can use named params
davidlaprade
commented
Apr 4, 2025
src/FlexVotingMultiGov.sol
Outdated
| import {FlexVotingBase} from "src/FlexVotingBase.sol"; | ||
| import {IFractionalGovernor} from "src/interfaces/IFractionalGovernor.sol"; | ||
|
|
||
| abstract contract FlexVotingMultiGov is FlexVotingBase, Ownable { |
There was a problem hiding this comment.
We don't need a whitelist
davidlaprade
force-pushed
the
multi-governor-client
branch
from
03bc563 to
f8c8e75
Compare
davidlaprade
force-pushed
the
multi-governor-client
branch
from
e15c058 to
d3b7a04
Compare
It was weird to begin with to have functions like `rawBalanceOf` and `deposit` and `withdraw` take a governor argument instead of a token argument. It's much more natural to think in terms of depositing/withdrawing/having a balance of a *token* than a governor. Also it quickly became clear in tests that this weirdness was more than inconvenient, as there were contexts where a deposit would need to be made, the token was available, but the governor was not -- and since you can't ask the token for the governor, we were stuck.
davidlaprade
force-pushed
the
multi-governor-client
branch
from
79c7dc1 to
022363a
Compare
This keeps biting me
davidlaprade
force-pushed
the
multi-governor-client
branch
from
0be0970 to
f3b6559
Compare
|
Coverage after merging multi-governor-client into client-sub-delegation will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82 should be merged before this