-
Notifications
You must be signed in to change notification settings - Fork 34
Add ability to sort courses and clear filters #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This works locally, but not on the preview deployments. I don't think fces even show up on the preview deployments, but I could be wrong edit: this is fixed |
xavilien
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xavilien
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to sort courses on the search page by several heuristics at once. These currently include
FCE
,TeachingRate
,CourseRate
,CourseNumber
, andUnits
, the first 3 of which are disabled unless the user is signed in. Each heuristic can also be assignedAscending
orDescending
.The user can drag and drop heuristics (called "sort options") to set their precedence for sorting, and press on its respective pill to toggle between
Ascending
andDescending
. The goal is to allow the user to do things like prioritize low FCE courses with high ratings, prioritize high unit courses that are low in course number, etc.(None selected)

(Some selected)

Also adds the ability to clear individual filters or all of them at once.
Closes #132
Closes #206
Closes #134
Closes #213
Type of change