Remove thx banner (and a few styling tweaks) #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cirex-web is attempting to deploy a commit to the ScottyLabs Team on Vercel. A member of the Team first needs to authorize it. |
cirex-web
commented
Feb 17, 2025
| <Header /> | ||
| </header> | ||
| <main className="relative flex min-h-full flex-col pt-[104px] md:h-screen md:flex-row md:justify-around"> |
There was a problem hiding this comment.
hardcoded pt? we can do better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was just going to remove the banner, but then I realized that the main layout was a bit jank (104px padding top?), so I changed it over a flexbox that doesn't overflow the main viewport. (The screen real-estate is a tad bit less, but it does make scrolling the courses list a bit easier. (you now can't inadvertendly scroll to the footer)). I also removed some uneeded absolute positioning styling and z-index classes for some true Yak Shaving
Type of change
How Has This Been Tested?
(diregard the awkward position of the ❤️. Seems like a bug with devtools)