Skip to content

Commit

Permalink
Revert "Add Pre-send warning for 1.38.1 bug (#450)" (#454)
Browse files Browse the repository at this point in the history
This reverts commit ca73c87.
  • Loading branch information
WorldLanguages authored Aug 28, 2024
1 parent 52fad54 commit d078786
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 20 deletions.
4 changes: 0 additions & 4 deletions i18n/en.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,6 @@ FeedbackPage:
Heading: We can't punish people. We are not the Scratch Team.
Description: "Scratch Addons is not affiliated with the Scratch website or the organizations that maintain it. We have no control of the content and the moderation on the Scratch website. {{ .Tag1Start }}There are many ways that you can report on the Scratch website.{{ .Tag1End }}"

MV3LoadBug:
Heading: There is a known issue causing all addons to stop working
Description: "Scratch Addons v1.38.1 has a known issue where using some addons may cause all of them to randomly stop working. Try disabling the Necropost Highlighter addon."

# Strings used for /scratch-messaging-transition
SMTPage:
ScratchMessagingLogoAlt: Scratch Messaging Extension logo
Expand Down
6 changes: 1 addition & 5 deletions layouts/shortcodes/specifics/feedback-form.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
heading: '{{ T "FeedbackPage.PreSendWarning.Variations.Punishment.Heading" }}',
description: '{{ T "FeedbackPage.PreSendWarning.Variations.Punishment.Description" ( dict "Tag1Start" (add $ts 1) "Tag1End" (add $ts 2) ) | htmlEscape }}',
},
MV3LoadBug: {
heading: '{{ T "FeedbackPage.PreSendWarning.Variations.MV3LoadBug.Heading" }}',
description: '{{ T "FeedbackPage.PreSendWarning.Variations.MV3LoadBug.Description" | htmlEscape }}',
}
}
},
submitButton: '{{ T "FeedbackPage.SubmitButton" }}'
Expand All @@ -46,4 +42,4 @@
<label class="form-check-label" for="feedback-addons-list">{{ T "FeedbackPage.SendEnabled" }}</label>
</div>
<button class="btn btn-primary" id="feedback-submit" type="button">{{ T "FeedbackPage.SubmitButton" }}</a>
</form>
</form>
11 changes: 0 additions & 11 deletions static/assets/js/feedback.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@ const variations = {
/\bst\b/,
]
},
MV3LoadBug: {
strings: {
...i18n.preSendWarning.variations.MV3LoadBug
},
patterns: [
/\baddons.*broke(?:n)?\b/,
/\bcrash(?:ed|es|ing)?\b/,
/\b(do(n't|esn't|\snot)|won't).*(load|work)\b/,
/\b(is\snot|isn't|stopped).*(loading|working)\b/,
]
},
}

let lastFeedbackRequestTime = localStorage.getItem("lastFeedbackRequestTime")
Expand Down

0 comments on commit d078786

Please sign in to comment.