Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add Pre-send warning for 1.38.1 bug" #454

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Revert "Add Pre-send warning for 1.38.1 bug" #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions i18n/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,6 @@ FeedbackPage:
Heading: We can't punish people. We are not the Scratch Team.
Description: "Scratch Addons is not affiliated with the Scratch website or the organizations that maintain it. We have no control of the content and the moderation on the Scratch website. {{ .Tag1Start }}There are many ways that you can report on the Scratch website.{{ .Tag1End }}"

MV3LoadBug:
Heading: There is a known issue causing all addons to stop working
Description: "Scratch Addons v1.38.1 has a known issue where using some addons may cause all of them to randomly stop working. Try disabling the Necropost Highlighter addon."

# Strings used for /scratch-messaging-transition
SMTPage:
ScratchMessagingLogoAlt: Scratch Messaging Extension logo
Expand Down
6 changes: 1 addition & 5 deletions layouts/shortcodes/specifics/feedback-form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
heading: '{{ T "FeedbackPage.PreSendWarning.Variations.Punishment.Heading" }}',
description: '{{ T "FeedbackPage.PreSendWarning.Variations.Punishment.Description" ( dict "Tag1Start" (add $ts 1) "Tag1End" (add $ts 2) ) | htmlEscape }}',
},
MV3LoadBug: {
heading: '{{ T "FeedbackPage.PreSendWarning.Variations.MV3LoadBug.Heading" }}',
description: '{{ T "FeedbackPage.PreSendWarning.Variations.MV3LoadBug.Description" | htmlEscape }}',
}
}
},
submitButton: '{{ T "FeedbackPage.SubmitButton" }}'
Expand All @@ -46,4 +42,4 @@
<label class="form-check-label" for="feedback-addons-list">{{ T "FeedbackPage.SendEnabled" }}</label>
</div>
<button class="btn btn-primary" id="feedback-submit" type="button">{{ T "FeedbackPage.SubmitButton" }}</a>
</form>
</form>
11 changes: 0 additions & 11 deletions static/assets/js/feedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@ const variations = {
/\bst\b/,
]
},
MV3LoadBug: {
strings: {
...i18n.preSendWarning.variations.MV3LoadBug
},
patterns: [
/\baddons.*broke(?:n)?\b/,
/\bcrash(?:ed|es|ing)?\b/,
/\b(do(n't|esn't|\snot)|won't).*(load|work)\b/,
/\b(is\snot|isn't|stopped).*(loading|working)\b/,
]
},
}

let lastFeedbackRequestTime = localStorage.getItem("lastFeedbackRequestTime")
Expand Down