configure: correctly handle systemd versions before 245 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKG_CHECK_MODULES macros need to have unique prefixes, or the latter ones are ignored. In configure.ac we were checking for SYSTEMD_JOURNAL twice, once for the presence of systemd in general, then again for namespace support. However, since the first call would already set the variables, the second check would re-use those. This results in namespace support getting enabled in systemd versions that don't support it, and the build failing.
|
Thank you for the PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKG_CHECK_MODULES macros need to have unique prefixes, or the latter ones are ignored. In configure.ac we were checking for SYSTEMD_JOURNAL twice, once for the presence of systemd in general, then again for namespace support. However, since the first call would already set the variables, the second check would re-use those.
This results in namespace support getting enabled in systemd versions that don't support it, and the build failing.