-
-
Notifications
You must be signed in to change notification settings - Fork 213
New iden paradigm #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
New iden paradigm #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefully this can get optimized
Expurple
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this
Co-authored-by: Dmitrii Aleksandrov <[email protected]>
Co-authored-by: Dmitrii Aleksandrov <[email protected]>
special thanks to @Huliiiiii for bringing forward the proposal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed,
Arc
,vtable
tricks are removed.The biggest behaviour change is late binding to early binding. previously the Iden is only rendered when the AST is being serialized, now that we pre-render it as we store that into the AST.
For majority of usecases in SeaORM though, since they're
'static str
anyway, there should be no difference.It is still possible to have
struct MyIden(String)
with some dynamic behaviour.@Huliiiiii