Skip to content

Camp 2025 Squeak fixes round 2 #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marschall
Copy link
Contributor

  • introduce Squeak specific Email package
  • no longer load Seaside-Squeak-Compatibility
  • move REST methods to same platform class

Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.82%. Comparing base (81f50ee) to head (e5b7dfe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   51.82%   51.82%           
=======================================
  Files        9151     9151           
  Lines       76690    76690           
=======================================
  Hits        39742    39742           
  Misses      36948    36948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not finish my review but we should try to remove the artefacts of the filetree writer that we no longer want in the source code: i.e. the filetree metadata and the indentation changes.

@marschall marschall force-pushed the squeak-fixes-camp-2025-2 branch from 79c7222 to 5f94099 Compare July 2, 2025 07:42
- introduce Squeak specific Email package
- no longer load Seaside-Squeak-Compatibility
- move REST methods to same platform class
@marschall marschall force-pushed the squeak-fixes-camp-2025-2 branch from 5f94099 to e5b7dfe Compare July 2, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants