Skip to content

Fix WAScreenshot issues #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marschall
Copy link
Contributor

  • implement HighDPI support
  • fix Pharo support

Fixes #1471

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (8d13c67) to head (58f3f9a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ckage/WAScreenshot.class/instance/clickVmEvent..st 0.00% 13 Missing ⚠️
...ckage/WAScreenshot.class/instance/uiScaleFactor.st 0.00% 8 Missing ⚠️
...WAScreenshot.class/instance/renderMouseClickOn..st 0.00% 7 Missing ⚠️
...ge/WAScreenshot.class/instance/clickMorphEvent..st 0.00% 5 Missing ⚠️
...s-Web.package/WAScreenshot.class/instance/morph.st 0.00% 5 Missing ⚠️
....package/WAScreenshot.class/instance/buttonCode.st 0.00% 3 Missing ⚠️
...-Web.package/WAScreenshot.class/instance/click..st 0.00% 3 Missing ⚠️
...kage/WAScreenshot.class/instance/handleVmEvent..st 0.00% 3 Missing ⚠️
...ls-Web.package/WAScreenshot.class/instance/form.st 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
- Coverage   51.78%   51.77%   -0.02%     
==========================================
  Files        9163     9167       +4     
  Lines       76738    76763      +25     
==========================================
  Hits        39742    39742              
- Misses      36996    37021      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- implement HighDPI support
- fix Pharo support
@marschall marschall force-pushed the highres-screenshot branch from 58f3f9a to 4e33020 Compare July 2, 2025 15:53
Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I just noticed a small improvement to do but looks good to me.

width: (form width / self uiScaleFactor) greaseInteger;
height: (form height / self uiScaleFactor) greaseInteger;
form: self form ] ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
form: self form ] ]
form: form ] ]

width: (form width / Display uiScaleFactor) greaseInteger;
height: (form height / Display uiScaleFactor) greaseInteger;
form: self form ] ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
form: self form ] ]
form: form ] ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAScreenshot issues
2 participants