-
Notifications
You must be signed in to change notification settings - Fork 73
Fix WAScreenshot issues #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix WAScreenshot issues #1472
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
- Coverage 51.78% 51.77% -0.02%
==========================================
Files 9163 9167 +4
Lines 76738 76763 +25
==========================================
Hits 39742 39742
- Misses 36996 37021 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- implement HighDPI support - fix Pharo support
58f3f9a
to
4e33020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I just noticed a small improvement to do but looks good to me.
width: (form width / self uiScaleFactor) greaseInteger; | ||
height: (form height / self uiScaleFactor) greaseInteger; | ||
form: self form ] ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form: self form ] ] | |
form: form ] ] |
width: (form width / Display uiScaleFactor) greaseInteger; | ||
height: (form height / Display uiScaleFactor) greaseInteger; | ||
form: self form ] ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form: self form ] ] | |
form: form ] ] |
Fixes #1471