Skip to content

#1468 no 404 if missing favicon #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2025

Conversation

SabineMa
Copy link
Contributor

@SabineMa SabineMa commented Jul 4, 2025

#1445
avoid throwing a 404 if there is no favicon
avoid showing cached versions of favicon

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (8d13c67) to head (88fc5c1).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...package/WAFaviconHandler.class/class/initialize.st 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
+ Coverage   51.78%   51.82%   +0.03%     
==========================================
  Files        9163     9154       -9     
  Lines       76738    76705      -33     
==========================================
+ Hits        39742    39753      +11     
+ Misses      36996    36952      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
It looks good. I would just want to see the 'categories.st' change reverted since it's reverting to an older format.

@jbrichau jbrichau merged commit 94c5469 into SeasideSt:master Jul 4, 2025
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants