This repository was archived by the owner on Apr 23, 2024. It is now read-only.
Add done attribute to shopping list #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
I have a second commit following this one on my branch at: https://github.com/DellanX/pygrocy/tree/feature/annotate-data-models. I'd like to close this PR before attempting that one, as that PR will fix a bunch of issues cause by null data, and adds |
SebRut
reviewed
Feb 5, 2024
| for item in shopping_list: | ||
| assert isinstance(item, ShoppingListProduct) | ||
| assert isinstance(item.id, int) | ||
| assert isinstance(item.done, int) |
There was a problem hiding this comment.
Sorry, I'm a bit out-of-the-loop regarding grocy, is int the correct type for done. Sounds like it should be a boolean.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I needed to be able to determine whether or not the item was checked off in Grocy. Thus I mapped the 'done' attribute over from the raw shopping list item.
NOTE: Tox didn't run out of the box correctly for me, I needed to add a comma on line 5 between TRAVIS and TRAVIS_* to get the test suite to run correctly.
Related issue (if applicable):
NA
Checklist