Refactor LogoScreen: Add docstring, rename variable, and add state flag #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
I believe this pull request is unnecessary because the work has already been covered in #730. |
|
NACK since this PR is superseded by the work in #718. However, if you think some of the changes here belong in there, I would add them as a review comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored LogoScreen by:
Reason: Improves code structure and documentation as part of the Code Cleanup for Loading Screens project, making it easier to maintain and extend (e.g., for future state-based logic).
Screenshots omitted: Changes are code-level (docstring, variable rename, state flag) with no UI impact. Full runtime testing failed due to missing 'spidev' (Raspberry Pi dependency) and import resolution issues (ModuleNotFoundError: seedsigner) on Windows, preventing screen rendering.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.
I plan to follow up with Step 2, refactoring OpeningSplashScreen and ScreensaverScreen to use the new image_path and is_active attributes, addressing inheritance impacts. Please let me know if this aligns with the priorities or if other changes are preferred!