[Refactor] Replace instructions_text with disappearing toast in ScanScreen#734
Closed
FazleRabbbiferdaus172 wants to merge 1 commit intoSeedSigner:devfrom
Conversation
bitcoinprecept
moved this from SoB In Progress
to SoB Needs Code Review
in @SeedSigner Development Board
FazleRabbbiferdaus172
force-pushed
the
refactor/non_emulator/DisappearingToast_scanScreen
branch
from
57bfffa to
024922f
Compare
Contributor
|
The TODO comment you reference ends in a question mark and unfortunately in this case I'm not convinced it's the right way to go. Once the message disappears, if you set the SeedSigner down, there's no longer any indication that it's still running: PXL_20250729_212028469_edit.mp4Whereas the current code would at least give some hint that the screen is still alive:
The UX for the toast needs work (the original tip on that screen was never ideal, but this presentation is worse):
But for now I'm a NACK on this change, mostly just due to the "it's not off but it looks like it's off" problem. For our security model, that's a pretty big potential mistake for a user to make. |
kdmukai
moved this from SoB Needs Code Review
to SoB In Progress
in @SeedSigner Development Board
Contributor
Author
|
should I close the pr? |
Contributor
I think so, yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the instruction text previously drawn directly onto the ScanScreen with a disappearing toast overlay. The change addresses the existing TODO comment in the codebase that suggested switching to a disappearing toast.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: