Skip to content

[Refactor] Replace instructions_text with disappearing toast in ScanScreen #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

FazleRabbbiferdaus172
Copy link

@FazleRabbbiferdaus172 FazleRabbbiferdaus172 commented Apr 16, 2025

Description

This PR replaces the instruction text previously drawn directly onto the ScanScreen with a disappearing toast overlay. The change addresses the existing TODO comment in the codebase that suggested switching to a disappearing toast.

Include screenshots of any new or modified screens (or at least explain why they were omitted)
image

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant