Skip to content

[l10n] ToolsCalcFinalWordScreen: adjusts spacing for locales w/larger fonts #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented May 20, 2025

Description

Fixes issue identified here: SeedSigner/seedsigner-translations#30 (comment)

Before / After:

ToolsCalcFinalWordShowFinalWordView_pick_word ToolsCalcFinalWordShowFinalWordView_pick_word


English (and any other "default" sized font) is unaffected:

ToolsCalcFinalWordShowFinalWordView_pick_word ToolsCalcFinalWordShowFinalWordView_pick_word


Changes

  • Keeps the bit display font size constant regardless of the body font size of the active locale.
  • The middle section ("Checksum") was not ignoring text height below baseline but that was unnoticeable in English since there are no chars below baseline in "Checksum". All the Asian fonts seem to render all kanji chars partially below baseline. Note how the "Checksum" section's bits are now snugged up a bit closer to their accompanying text in the Chinese screenshot.
  • Very minor 1-pixel spacing adjustment for locales with larger body font sizes to help avoid having the bottom line run into the button.

This pull request is categorized as a:

  • Other: UX enhancement

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

@jdlcdl
Copy link

jdlcdl commented May 22, 2025

ACK (having seen screenshots for all locales that have a current pr), as well as running on pi0 device. I see no problems at this point in time.

@newtonick newtonick added this to the 0.8.6 milestone May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 8.6 Needs Code Review
Development

Successfully merging this pull request may close these issues.

3 participants