[Bugfix] Solve raw hex display of OP_RETURN for non-latin alphabets #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvroble
changed the title
kdmukai
reviewed
Jun 10, 2025
| @@ -753,7 +763,7 @@ def __post_init__(self): | |||
| self.components.append(TextArea( | |||
| text=text, | |||
| font_name=GUIConstants.FIXED_WIDTH_FONT_NAME, | |||
| font_size=GUIConstants.get_body_font_size(), | |||
| font_size=GUIConstants.BODY_FONT_SIZE["default"], | |||
There was a problem hiding this comment.
I would add a comment here to explain why we want to force the default size here.
There was a problem hiding this comment.
Something like Use default font size for hex text readability?
|
I have not carefully reviewed all the changes, but my guess is that 2f1094e on its own is sufficient. Can you confirm? |
|
For some reason, it isn't: That's why I refactored the code in cfb5a5c to go char by char filling the lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the wrong display of the raw hex OP_RETURN for non-latin alphabets.
Before:
After:
Two options here:
Commit cfb5a5c: (this one may be just right if the TextArea is scrollable)
Commit 2f1094e:
This one makes the screen to use always the default font size for the hex content.
Include screenshots of any new or modified screens (or at least explain why they were omitted)
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.