Skip to content

[Test suite] Exhaustively test PSBTParser with all supported script types #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jun 4, 2025

Description

Creates a test structure to exhaustively test the PSBTParser against all supported script types in every conceivable combination in the most DRY way possible.

Adds the PSBTTestData class: contains predefined PSBT input and output snippets for all supported single-signature and multisig script types. These snippets can be mixed and matched as needed for the exhaustive tests. Resides in its own class so that other tests can potentially re-use the test data.


This pull request is categorized as a:

  • Other: Test suite enhancement / additional tests

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • Yes

I have tested this PR on the following platforms/os:

  • Other: Test suite runs in CI or in local dev but generally not on the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 9.0 Needs Code Review
Development

Successfully merging this pull request may close these issues.

1 participant