[java] remove guava from client bindings #12737 #13739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qodo-merge-pro
bot
added
P-enhancement
|
PR Description updated to latest commit (e358e2c)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit b2f4ae5)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
joerg1985
force-pushed
the
removed-guava-from-the-client
branch
3 times, most recently
from
bdaa13e to
d541c23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13739 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 86 86
Lines 5272 5272
Branches 220 220
=======================================
Hits 3088 3088
Misses 1964 1964
Partials 220 220 ☔ View full report in Codecov by Sentry. |
joerg1985
force-pushed
the
removed-guava-from-the-client
branch
3 times, most recently
from
55f528b to
b2f4ae5
Compare
|
@titusfortner could you please have a look at this one? |
|
I'm assuming there's no easy way to mark these as deprecated? |
|
As diemol wrote: |
|
" Do we want to wait for 5.0 to make this change? " - I think that might be a better option and the blog can linked to the major changes happening in 5.0 and as part of the migration guide from 4.0 to 5.0. |
|
I don't see why we need to wait for Selenium 5. This is an isolated change we can handle before that. Then, Selenium 5 would have less breaking changes. |
|
To be honest, i'd kind of like selenium to behave a little more like other projects and put upcoming breaking changes in Selenium 5 at this point. |
|
I am happy with pushing it to Selenium 5, i was only asking because the issue had no target milestone at all. So i will add it to the Selenium 5 milestone. |
|
Sorry @diemol i missed your comment |
joerg1985
force-pushed
the
removed-guava-from-the-client
branch
from
b2f4ae5 to
43a62c1
Compare
CI Failure Feedback 🧐(Checks updated until commit 99bb3cd)
|
|
So I just also ran into this issue. Selenium 5 doesn't seem to be on the horizon yet and the changes here are absolutely tiny. Is it possible to ship this anyway in a minor version? |
|
At this point it is a matter of creating a blog post, showing people how to migrate, wait a couple of months tops, and then do it. The problem is that maintainers are having less and less time to do this minor things. |
That sound a bit overkill to me, considering that Please note that I (and likely most other people or dependency update bots like dependabot or renovate) also don't read random blog posts that are not mentioned in release notes. If I had to do this change I would include a short "breaking changes"-section in the release notes, like this:
and I think that should be enough.
Okay, if I can help somehow let me know. |
|
I agree. But from experience, we have learned that we need to show how users can migrate in detail. A breaking change needs to be announced because people don't expect their code to not compile after a version bump. We care about informing people in advance in those cases. |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This PR is the final part of #12737 but will break the compatibility of the
org.openqa.selenium.support.ui.ExpectedConditioninterface.A blog post must warn the users to ensure there are no tickets raised for this, see #12737 for details.
Types of changes
Checklist
Type
enhancement, breaking change
Description
ExpectedConditioninterface, now usingjava.util.function.Functioninstead.BUILD.bazelfile to remove Guava from dependencies.ExpectedConditioninterface which may affect existing implementations.Changes walkthrough
ExpectedCondition.java
Removal of Guava Dependency in ExpectedConditionjava/src/org/openqa/selenium/support/ui/ExpectedCondition.java
com.google.common.base.Function.java.util.function.Function.BUILD.bazel
Update BUILD.bazel to Remove Guava Dependencyjava/src/org/openqa/selenium/support/ui/BUILD.bazel
com.google.guava:guavafrom dependencies.