[java]: allow setting custom timeout for DevTools

[navin772]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #14912

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement, Bug fix

---

Description

• Added an overloaded constructor to set custom timeouts in DevTools.

• Introduced a setTimeout method to validate and update timeout duration.

• Ensured default timeout remains at 10 seconds for backward compatibility.

• Improved error handling for invalid timeout values.

---

Changes walkthrough 📝

	Relevant files
Enhancement	DevTools.java Support custom timeout and validation in `DevTools`            java/src/org/openqa/selenium/devtools/DevTools.java Added an overloaded constructor to accept custom timeout. Introduced a setTimeout method for timeout validation and assignment. Updated default timeout initialization for flexibility. Enhanced error handling for timeout validation. +15/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Thread Safety The timeout field is not marked as volatile or synchronized, which could cause visibility issues in multi-threaded scenarios when timeout is updated via setTimeout private Duration timeout = Duration.ofSeconds(10);

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Add an upper bound validation to prevent excessive timeout values that could lead to resource issues Add an upper bound validation for the timeout value to prevent potential resource exhaustion or performance issues. A reasonable maximum timeout (e.g., 5 minutes) should be enforced. java/src/org/openqa/selenium/devtools/DevTools.java [222-228] public void setTimeout(Duration timeout) { Require.nonNull("Timeout duration", timeout); if (timeout.isNegative() || timeout.isZero()) { throw new IllegalArgumentException("Timeout must be positive"); } + if (timeout.toMinutes() > 5) { + throw new IllegalArgumentException("Timeout cannot exceed 5 minutes"); + } this.timeout = timeout; } Apply this suggestion Suggestion importance[1-10]: 7 Why: Adding an upper bound for timeout values is a good practice to prevent resource exhaustion and system hangs. The suggestion provides a reasonable limit of 5 minutes and includes proper validation logic.	7

[diemol]

How would an end user set the timeout locally or in the Grid?

[navin772]

@diemol I am not much clear about it. Initially, I thought the user can create a DevTools object with custom timeout, but I think that is not convenient.
Any suggestions/feedback are appreciated.

[diemol]

Thinking more about this... The DevTools code will go away when we move to BiDi completely.

So, adding a whole new interface seems a bit to much in this case. Maybe we can just increase the timeout to 20 or 30 seconds and call it a day.

I don't think we should invest in this complexity considering this will go away.

What do you think?

[navin772]

@diemol I will ask the issue creator for their approx timeout value and we can update it here if its upto 30 seconds, or else if it is 30+, we can update to 30 and tell them to wait for BiDi.

[diemol]

Sounds good.

[navin772]

@diemol @pujagani I have increased the timeout to 30s for CDP as discussed above.

We can merge this and work on configurable timeouts for BiDi. I can give it a try.