-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Increment WebDriver
towards nullability
#15228
Open
RenderMichael
wants to merge
15
commits into
SeleniumHQ:trunk
Choose a base branch
from
RenderMichael:webdriver-nullable-1
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
13d222a
[dotnet] Increment `WebDriver` towards nullability
RenderMichael bfa00b3
minimize some diffs with error throwing
RenderMichael a7ace95
further minimize some diffs with error throwing
RenderMichael 43012fd
Annotate more of `WebDriver`, leaving only the commands where we need…
RenderMichael 4060d7c
fix nullability of adjacent types
RenderMichael 46cea73
remove changes to Execute
RenderMichael d460905
remove more
RenderMichael 0226224
revert final change about Execute
RenderMichael 4c1f3be
Executing null command name throws, document this
RenderMichael 257f8ff
Merge branch 'trunk' into webdriver-nullable-1
RenderMichael b9561da
Use new `EnsureValueIsNotNull` helper
RenderMichael eb3dd0f
cleanup
RenderMichael 0746e38
Merge branch 'trunk' into webdriver-nullable-1
RenderMichael 4f3c8c5
`Execute` cannot return `null`
RenderMichael 1fe285b
Merge branch 'webdriver-nullable-1' of https://github.com/RenderMicha…
RenderMichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that passing in
null
for the name will throw an exception anyway, This just clarifies the exception for any user who does this.