-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Annotate nullability on more of WebElement
#15230
Open
RenderMichael
wants to merge
11
commits into
SeleniumHQ:trunk
Choose a base branch
from
RenderMichael:webelement-nullable-2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2ea99a3
[dotnet] Annotate nullability on more of `WebElement`
RenderMichael 696832f
Handle nullability of GetCssValue
RenderMichael e8c53af
Implement nullability on more of `WebElement`
RenderMichael bca2dc8
fix typo
RenderMichael c55eb00
improve error message
RenderMichael d895b6b
Merge branch 'trunk' into webelement-nullable-2
RenderMichael 7b0f681
Merge branch 'trunk' into webelement-nullable-2
RenderMichael c07436f
Use new `EnsureValueIsNotNull` hlper
RenderMichael bb69c82
Merge branch 'trunk' into webelement-nullable-2
RenderMichael fd977e0
Merge branch 'trunk' into webelement-nullable-2
RenderMichael cabb1e8
Merge branch 'trunk' into webelement-nullable-2
RenderMichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test it carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to be very careful with this, to change no behavior. I read the spec, it says this will always be a string.
The only reason I am comfortable with this change, is because it would previously be a
NullReferenceException
if this werenull
. This way, users have something better to report if there is a bug here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good insight. Please give me a chance to revisit it.