[dotnet] Unify protected and internal Execute methods

[RenderMichael]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

protected + internal -> protected internal

Motivation and Context

Less overloads, shorter stack traces, less maintenance.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement, Bug fix

---

Description

• Unified InternalExecute and Execute methods into a single protected internal method.

• Replaced all occurrences of InternalExecute with Execute across multiple classes.

• Added null checks for constructor parameters in HttpCommandInfo.

• Simplified and streamlined method calls for better maintainability and reduced stack traces.

---

Changes walkthrough 📝

	Relevant files
Enhancement	10 files Alert.cs Replaced `InternalExecute` with `Execute` in alert handling. +4/-4      CookieJar.cs Replaced `InternalExecute` with `Execute` in cookie management. +5/-5      Logs.cs Replaced `InternalExecute` with `Execute` in log retrieval. +2/-2      Navigator.cs Replaced InternalExecuteAsync with ExecuteAsync in navigation methods. +4/-4      ShadowRoot.cs Replaced InternalExecute with Execute in shadow DOM element handling. +2/-2      TargetLocator.cs Replaced InternalExecute with Execute in frame and window switching. +8/-8      Timeouts.cs Replaced `InternalExecute` with `Execute` in timeout management. +2/-2      WebDriver.cs Unified InternalExecute and Execute methods into a single protected internal method. +2/-25    WebElement.cs Replaced InternalExecute with Execute in element-specific commands. +1/-1      Window.cs Replaced `InternalExecute` with `Execute` in window management. +7/-7
Error handling	1 files HttpCommandInfo.cs Added null checks for constructor parameters.                        +3/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review API Change The Execute method visibility changed from protected to protected internal. Validate this change does not break any existing code that inherits from WebDriver. protected internal virtual Response Execute(string driverCommandToExecute, Dictionary<string, object> parameters) { return Task.Run(() => this.ExecuteAsync(driverCommandToExecute, parameters)).GetAwaiter().GetResult(); } Exception Handling New null checks were added to constructor parameters. Verify this change does not affect existing code that may have been passing null values. this.ResourcePath = resourcePath ?? throw new ArgumentNullException(nameof(resourcePath)); this.Method = method ?? throw new ArgumentNullException(nameof(method));

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Improve null parameter validation Add null checks for constructor parameters before assigning them to avoid potential null reference exceptions later in the code execution. dotnet/src/webdriver/HttpCommandInfo.cs [55-58] public HttpCommandInfo(string method, string resourcePath) { - this.ResourcePath = resourcePath ?? throw new ArgumentNullException(nameof(resourcePath)); - this.Method = method ?? throw new ArgumentNullException(nameof(method)); + if (method is null) + { + throw new ArgumentNullException(nameof(method)); + } + if (resourcePath is null) + { + throw new ArgumentNullException(nameof(resourcePath)); + } + this.Method = method; + this.ResourcePath = resourcePath; } Apply this suggestion Suggestion importance[1-10]: 3 Why: While the suggestion proposes a more explicit null-checking approach, the existing code using null-coalescing operators is equally effective and more concise. The change would only marginally improve code readability.	3

[RenderMichael]

This is actually not a breaking change!

[RenderMichael]

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/protected-internal#overriding-protected-internal-members

[nvborisenko]

I don't trust.

[RenderMichael]

I validated it myself (in the screenshot) and the docs verify this. It's safe!

[nvborisenko]

compile time or at binary level?

[RenderMichael]

Hmmm, I'm not sure about binary compatibility. Let me do more research.

[RenderMichael]

I asked the .NET team, and they said it is not a source or a binary breaking change

dotnet/roslyn#77157 (reply in thread)

[nvborisenko]

I don't trust.