Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12549 fix atoms generation lowdash #15247

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Issue 12549 fix atoms generation lowdash #15247

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b71e909
Updating the atom frament bazel file so that "_" is not used as the e…
ahalbrock Jan 27, 2025
0c56457
Added the exported function name to the string substitution list. At…
ahalbrock Jan 28, 2025
6dc9ac4
Properly adding the exported function variable to the wrapper.
ahalbrock Jan 28, 2025
15732b0
Merge branch 'trunk' into Issue_12549_FixAtomsGenerationLowdash
ahalbrock Feb 5, 2025
96667c4
Merge branch 'trunk' into Issue_12549_FixAtomsGenerationLowdash
ahalbrock Feb 6, 2025
e99739c
Merge branch 'trunk' into Issue_12549_FixAtomsGenerationLowdash
ahalbrock Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions javascript/private/fragment.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
load("@io_bazel_rules_closure//closure:defs.bzl", "closure_js_binary", "closure_js_library")

EXPORT_FUNCTION_NAME = '___exportedFunc___'

def _internal_closure_fragment_export_impl(ctx):
ctx.actions.write(
output = ctx.outputs.out,
content = """
goog.require('%s');
goog.exportSymbol('_', %s);
""" % (ctx.attr.module, ctx.attr.function),
goog.exportSymbol('%s', %s);
""" % (ctx.attr.module, EXPORT_FUNCTION_NAME, ctx.attr.function),
)

_internal_closure_fragment_export = rule(
Expand Down Expand Up @@ -59,10 +61,7 @@ def closure_fragment(
# See http://code.google.com/p/selenium/issues/detail?id=1333
wrapper = (
"function(){" +
"return (function(){%output%; return this._.apply(null,arguments);}).apply({" +
"navigator:typeof window!='undefined'?window.navigator:null," +
"document:typeof window!='undefined'?window.document:null" +
"}, arguments);}"
"return (function(){%output%; return this." + EXPORT_FUNCTION_NAME + ".apply(null,arguments);}).apply(window, arguments);}"
)

browser_defs = {
Expand Down