Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Refine logger initialization with correct class literal #15289

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

iampopovich
Copy link
Contributor

@iampopovich iampopovich commented Feb 14, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

This pull request includes several changes to improve the logging in the selenium project. The changes primarily involve updating the logger initialization to use the correct class names.

Logging improvements:

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Corrected logger initialization to use appropriate class names.

  • Updated BoundZmqEventBus to use BoundZmqEventBus.class.getName().

  • Updated UnboundZmqEventBus to use UnboundZmqEventBus.class.getName().

  • Updated JmxTest to use JmxTest.class.getName() for logger.


Changes walkthrough 📝

Relevant files
Bug fix
BoundZmqEventBus.java
Fix logger class reference in BoundZmqEventBus                     

java/src/org/openqa/selenium/events/zeromq/BoundZmqEventBus.java

  • Updated logger initialization to use BoundZmqEventBus.class.getName().
  • Ensures the logger references the correct class.
  • +1/-1     
    UnboundZmqEventBus.java
    Fix logger class reference in UnboundZmqEventBus                 

    java/src/org/openqa/selenium/events/zeromq/UnboundZmqEventBus.java

  • Updated logger initialization to use
    UnboundZmqEventBus.class.getName().
  • Ensures the logger references the correct class.
  • +1/-1     
    JmxTest.java
    Fix logger class reference in JmxTest                                       

    java/test/org/openqa/selenium/grid/router/JmxTest.java

  • Updated logger initialization to use JmxTest.class.getName().
  • Ensures the logger references the correct class.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @iampopovich iampopovich marked this pull request as ready for review February 14, 2025 21:35
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant