[java] Refine logger initialization with correct class literal#15289
Merged
VietND96 merged 1 commit intoSeleniumHQ:trunkfrom Feb 17, 2025
Merged
[java] Refine logger initialization with correct class literal#15289VietND96 merged 1 commit intoSeleniumHQ:trunkfrom
VietND96 merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
pujagani
approved these changes
Feb 17, 2025
Contributor
pujagani
left a comment
There was a problem hiding this comment.
Thank you! @iampopovich
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
This pull request includes several changes to improve the logging in the
seleniumproject. The changes primarily involve updating the logger initialization to use the correct class names.Logging improvements:
java/src/org/openqa/selenium/events/zeromq/BoundZmqEventBus.java: Updated the logger initialization to useBoundZmqEventBus.class.getName()instead ofEventBus.class.getName().java/src/org/openqa/selenium/events/zeromq/UnboundZmqEventBus.java: Updated the logger initialization to useUnboundZmqEventBus.class.getName()instead ofEventBus.class.getName().java/test/org/openqa/selenium/grid/router/JmxTest.java: Updated the logger initialization to useJmxTest.class.getName()instead ofLocalNode.class.getName().Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Corrected logger initialization to use appropriate class names.
Updated
BoundZmqEventBusto useBoundZmqEventBus.class.getName().Updated
UnboundZmqEventBusto useUnboundZmqEventBus.class.getName().Updated
JmxTestto useJmxTest.class.getName()for logger.Changes walkthrough 📝
BoundZmqEventBus.java
Fix logger class reference in BoundZmqEventBusjava/src/org/openqa/selenium/events/zeromq/BoundZmqEventBus.java
BoundZmqEventBus.class.getName().UnboundZmqEventBus.java
Fix logger class reference in UnboundZmqEventBusjava/src/org/openqa/selenium/events/zeromq/UnboundZmqEventBus.java
UnboundZmqEventBus.class.getName().JmxTest.java
Fix logger class reference in JmxTestjava/test/org/openqa/selenium/grid/router/JmxTest.java
JmxTest.class.getName().