-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[rb] add guard for browser version #15899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] add guard for browser version #15899
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…' into rb_add_guard_for_browser_version
…' into rb_add_guard_for_browser_version
User description
💥 What does this PR do?
This PR adds support to exclude tests based on the browser version
🔧 Implementation Notes
I implemented this way to leverage existent browser information on the test environment
🔄 Types of changes
PR Type
Enhancement
Description
• Add browser version guard support for test exclusion
• Integrate version condition into test guards system
• Apply version exclusion to FedCM spec tests
Changes walkthrough 📝
fedcm_spec.rb
Add version exclusion to FedCM tests
rb/spec/integration/selenium/webdriver/fedcm_spec.rb
• Add version exclusion parameter to FedCM test describe block
•
Exclude specific Chrome version 138.0.7204.23 from tests
spec_helper.rb
Register version guard condition
rb/spec/integration/selenium/webdriver/spec_helper.rb
• Add version condition to guards system
• Register browser_version
from GlobalTestEnv as guard condition
test_environment.rb
Add browser version accessor method
rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
• Add browser_version method to access driver capabilities
• Refactor
current_env to use new browser_version method
• Extract browser
version logic into dedicated method