Skip to content

Refactor deprecated DBConnection function call #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

robinwiel
Copy link
Contributor

The calls to getConnectionRef have been deprecated since MediaWiki 1.39. getConnectionRef() already redirects to getConnection(), but now we call this function directly to remove deprecation notices.

@robinwiel
Copy link
Contributor Author

@JeroenDeDauw could you check? was CI broken already for 1.43?

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (1bb9e88) to head (0f00f39).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage     76.12%   76.12%           
  Complexity      719      719           
=========================================
  Files            36       36           
  Lines          2325     2325           
=========================================
  Hits           1770     1770           
  Misses          555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alistair3149
Copy link

The CI is broken prior and unrelated to this PR.
Changes LGTM, thanks for submitting the PR! 🎉

@alistair3149 alistair3149 merged commit dc47c00 into SemanticMediaWiki:master Jul 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants