Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nsedits #185

Closed
wants to merge 21 commits into from
Closed

Nsedits #185

wants to merge 21 commits into from

Conversation

alex-mashin
Copy link
Collaborator

@alex-mashin alex-mashin commented Dec 27, 2021

This PR is made in reference to: #169

Property type: record (formally page).
Property ID: '___USEREDITCNT'.
Property structure:

  • '___USEREDITCNT_NS': _num (namespace number),
  • '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
    Property domain: User namespace.
    Property uniqueness: one value per namespace provided user has made edits in it.
    Property annotator class: UserEditCountPropertyAnnotator.
    Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.
    Minor corrections to other tests necessary to make them run.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namesoace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

alex-mashin and others added 20 commits October 30, 2021 23:51
Property type: record (formally page).
Property ID: '___USEREDITCNT'.
Property structure:
* '___USEREDITCNT_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namesoace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
Property type: record (formally page).
Property ID: '___USEREDITCNTNS'.
Property structure:
* '___USEREDITCNTNS_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namespace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
Property type: record (formally page).
Property ID: '___USEREDITCNTNS'.
Property structure:
* '___USEREDITCNTNS_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namespace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
Property type: record (formally page).
Property ID: '___USEREDITCNT'.
Property structure:
* '___USEREDITCNT_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.
Minor corrections to other tests necessary to make them run.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namesoace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
Property type: record (formally page).
Property ID: '___USEREDITCNT'.
Property structure:
* '___USEREDITCNT_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namesoace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
Property type: record (formally page).
Property ID: '___USEREDITCNT'.
Property structure:
* '___USEREDITCNT_NS': _num (namespace number),
* '___USEREDITCNTNS_CNT': _num (user's edit count in this namespace).
Property domain: User namespace.
Property uniqueness: one value per namespace provided user has made edits in it.
Property annotator class: UserEditCountPropertyAnnotator.
Property annotator test class: UserEditCountPerNsPropertyAnnotatorTest.

{{#ask:}} query examples:

Edit count rating per user per namespace:
{{#ask:[[-User edit count per namesoace::+]]
| mainlabel = -
| ? -User edit count per namespace
| ? Namespace
| ? Edit count
| sort = Edit count
| order = DESC
}}

Certain user's edits in the main namespace:
{{#ask:[[-User edit count per namespace::User:Alex Mashin]]
[[Namespace::0]]
| ? Edit count =
| mainlabel = -
}}

Made in reference to #169.
update GitHub Actions CI workflow
updated badges
fixed codecov path cleaning
fix wrong path for composer update
@hexmode
Copy link
Member

hexmode commented Dec 27, 2021

I started to introduce the namespace property early in 2021, but didn't finish it up. @cicalese and I are finishing it up now and were talking about adding the namespace id as well as the canoniclal name for the namespace.

How does would the (not yet implemented) __NAMESPACE_ID relate to your __USEREDITCNT_NS property?

Could both be used in the same query?

@alex-mashin
Copy link
Collaborator Author

How does would the (not yet implemented) __NAMESPACE_ID relate to your __USEREDITCNT_NS property?
Could both be used in the same query?

It's described in the comment to the pull request.

@hexmode
Copy link
Member

hexmode commented Dec 28, 2021

This PR cannot be used as is.

  • It makes unnecessary and unwanted changes to main.yml, backing out recent work (e.g. the addition of 1.37).
  • It causes the currently passing 1.35 tests to fail.
  • It adds back the saved service object (MediaWikiServices instance should not be saved #178).
  • etc.

Please isolate your branch to the changes you want and create a new PR.

@hexmode hexmode closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants