-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error when using intro and outro text #854
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
============================================
- Coverage 40.80% 40.77% -0.04%
- Complexity 2404 2410 +6
============================================
Files 81 81
Lines 7850 7856 +6
============================================
Hits 3203 3203
- Misses 4647 4653 +6 ☔ View full report in Codecov by Sentry. |
could you check this out? @gesinn-it-ilm |
@JeroenDeDauw could you please review this PR? Thanks. |
Costs too many brain cycles. If another dev vouches for this code I am happy to merge |
I will check it soon on my side, I was also planning to do a few updates to carousel format |
I'm sorry for the delay. As pointed out here the error shows when Datatables is called from the Special:Ask page and Therefore
as in (I will merge it, then I will add a comment in the code with instructions to fix the original Datatables solution if needed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assessment & tested
Fixes issue: #853
i first checked how SMW handels this with broadtable and pretty much just moved this code