Skip to content

Fix for #614 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix for #614 #870

merged 2 commits into from
Mar 28, 2025

Conversation

D-Groenewegen
Copy link
Contributor

Fix for #614. When no template is used, removes the html (a div element with the 'srf-incoming' class) from the result so that it allows for further reuse.

@gesinn-it-gea
Copy link
Member

Thanks for your PR! At the moment, the changed file is not covered by any tests: https://app.codecov.io/gh/SemanticMediaWiki/SemanticResultFormats/blob/master/formats%2Fincoming%2FSRF_Incoming.php. Do you think you can add some testing?

@D-Groenewegen
Copy link
Contributor Author

Apologies for the delay - I was hit with the man flu shortly afterwards. I can't currently find the time to add a test, but when I do, I can give it a try. Any guide we should be following?

@gesinn-it-gea
Copy link
Member

@D-Groenewegen ...take a look at the existing tests, maybe start with the JSONScript tests. There are also JSONScript tests in SMW itself. See also: https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/README.md

@jaideraf jaideraf added this to the 5.0.0 milestone Jan 19, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (e09a547) to head (bc9bc44).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
formats/incoming/SRF_Incoming.php 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #870      +/-   ##
============================================
+ Coverage     45.52%   45.55%   +0.03%     
+ Complexity     2319     2318       -1     
============================================
  Files            80       80              
  Lines          9050     9044       -6     
============================================
  Hits           4120     4120              
+ Misses         4930     4924       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeroenDeDauw JeroenDeDauw merged commit d83aa9a into SemanticMediaWiki:master Mar 28, 2025
6 of 7 checks passed
JeroenDeDauw added a commit that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants