Fix CI #875
Fix CI #875
Conversation
Since [0] It runs composer test and composer phpunit meaning right now it is running phpunit twice. We cleanup composer a bit. Also use the anonymous git clone url and not the ssh one for the submodule. [0] gesinn-it-pub/docker-compose-ci@08783a0
| @@ -83,8 +83,7 @@ | |||
| }, | |||
| "scripts":{ | |||
| "test": [ | |||
| "@analyze", | |||
| "@phpunit" | |||
There was a problem hiding this comment.
This also changes the behavior for people that run composer test locally. I suspect the issue you are fixing comes from the GH Actions config
There was a problem hiding this comment.
Yup. Unless gesinn-it-pub/docker-compose-ci@08783a0 gets reverted.
There was a problem hiding this comment.
The readme specifies > This extension provides unit and integration tests and is usually run by a continues integration platform but can also be executed locally using the shortcut command composer phpunit from the extension base directory.
Anyways. This unblocks the CI, so either this should be merged or gesinn-it-pub/docker-compose-ci@08783a0 reverted.
There was a problem hiding this comment.
I think we should revert gesinn-it-pub/docker-compose-ci@08783a0
There was a problem hiding this comment.
This is mainly because many other extensions are using docker-compose-ci. Forcing them to change their compose setup is not ideal.
Since [0] It runs composer test and composer phpunit meaning right now it is running phpunit twice.
We stop running phpunit under "test" as it is called afterwards.
Also use the anonymous git clone url and not the ssh one for the submodule.
[0] gesinn-it-pub/docker-compose-ci@08783a0
Fixes #872