-
-
Notifications
You must be signed in to change notification settings - Fork 80
UI improvements to dataTables #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements to dataTables #879
Conversation
- Allow add condition button to span the whole container - Fix incorrect wrapping for and/or button
Also refactor icon styles into mixins
resources/tokens.less
Outdated
* | ||
* TODO: Figure out a way to polyfill tokens for dark mode | ||
*/ | ||
/** @since v1.16.0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be in the same file? I'm worried that having this section at the bottom is easy to overlook when updating the preceding copied codex token code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then again, maybe we never need to update it? Can we drop these copies once we require MW 43 or later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be in the same file? I'm worried that having this section at the bottom is easy to overlook when updating the preceding copied codex token code.
It can be in a separate LESS file and imported through token.less
. Will reorganize it in the same PR.
Then again, maybe we never need to update it? Can we drop these copies once we require MW 43 or later?
I would suggest keeping a copy so that we can keep compatibility across MW versions. Design systems like Codex are often an evolving standard (and it did move much quicker than OOUI) and each MW version bundles with a different version of Codex. There are many fixes and improvements that are useful in the newer version of Codex, and having the newer version of Codex means that we can decouple UI development from the oldest Codex/MW version that we have to support.
We might be able to drop these copies somewhat in 1.43 if we switch to use Codex for HTML generation in PHP, but even Codex PHP is a relatively new thing so that is probably years down the line until it gets somewhat stable for SMW to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be in a separate LESS file and imported through token.less. Will reorganize it in the same PR.
Done. I have separated the tokens into three files.
tokens.less
serves as the entry point that is used to be imported by other LESS files if needed, or any other SRF tokens in the future.tokens-codex.less
is a copy of the current Codex Design Tokenstokens-codex-polyfill.less
contains the polyfill needed for Codex since MW 1.43.
Recording.2024-12-18.020126.1.mp4