Cherry-pick 7 ladybird PRs #25372
Merged
Cherry-pick 7 ladybird PRs #25372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2c8fb49)
Previously, the value sanitization algorithm would not trim whitespace for inputs of type URL or email, if they didn't also contain any newlines. (cherry picked from commit c4b8231)
(cherry picked from commit eb4e40b)
(cherry picked from commit 2d75479)
This change ensures that the value sanitization algorithm is run and the text cursor is set to the correct position when the type attribute of an input is changed. (cherry picked from commit 1b74104)
github-actions
bot
added
the
👀 pr-needs-review
This was added in 9d03ea6 for LibWeb/DumpLayoutTree/main.cpp. That utility was moved to LibViewView in SerenityOS#14018 and then deleted in SerenityOS#18879 after SerenityOS#17836 moved that functionality to headless-browser. No behavior change.
(cherry picked from commit b688bbf)
The IPCs to request a page's text, layout tree, etc. are currently all synchronous. This can result in a deadlock when WebContent also makes a synchronous IPC call, as both ends will be waiting on each other. This replaces the page info IPCs with a single, asynchronous IPC. This new IPC is promise-based, much like our screenshot IPC. (cherry picked from commit 3332230)
This corresponds to a recent change in the spec: w3c/webcrypto#372 Inspired by the following review comment: LadybirdBrowser/ladybird#1877 (comment) (cherry picked from commit ee3b86c)
This corresponds to a recent change in the spec: w3c/webcrypto#379 (cherry picked from commit efad0b5)
(cherry picked from commit 8535609)
(cherry picked from commit f80fca2)
Corresponds to whatwg/html#10091 (cherry picked from commit 36f8dfa)
nico
force-pushed
the
bulk_sync_1731415186
branch
from
207b34d to
f6593ea
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1337
LadybirdBrowser/ladybird#1360
LadybirdBrowser/ladybird#1447
LadybirdBrowser/ladybird#1970
LadybirdBrowser/ladybird#1934
LadybirdBrowser/ladybird#2084
LadybirdBrowser/ladybird#2223
Also remove unused
OutOfProcessWebView::dump_layout_treeto make LadybirdBrowser/ladybird#1447 actually build.