Skip to content

Meta: Build system now supports Clang 19 #26074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isif00
Copy link

@isif00 isif00 commented Jul 27, 2025

This PR improves the find_compiler.sh script to ensure reliable detection of Clang 19 and future releases #25123 .

Key Changes:

  • Rewrote find_newest_compiler() to dynamically scan $PATH for binaries matching <compiler>-<version> (e.g., clang-19).
  • Automatically selects the compiler with the supported and highest major version number.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 27, 2025
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@isif00 isif00 force-pushed the feature/clang-19-support branch from 21f9808 to 2e2d407 Compare July 27, 2025 20:12
@isif00 isif00 changed the title Meta: find_compiler.sh: Detect highest Clang version. Meta: build system now supports Clang 19 Jul 27, 2025
@isif00 isif00 force-pushed the feature/clang-19-support branch 2 times, most recently from 334c891 to 150bd43 Compare July 27, 2025 21:20
@isif00 isif00 changed the title Meta: build system now supports Clang 19 Meta: Build system now supports Clang 19 Jul 27, 2025
@isif00 isif00 force-pushed the feature/clang-19-support branch from 150bd43 to 31a203f Compare July 27, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 pr-needs-review PR needs review from a maintainer or community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants