action: Use setup-ninja instead of setup-cpp and use absoulte paths for cmake invocation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
force-pushed
the
bump-llvm-14-0-6
branch
13 times, most recently
from
35f7ed0 to
d7bf1ab
Compare
All the platforms we're targeting have `clang` as `clang-14` already in the path, so let's sidestep the strange include pathing problems the latest versions of this action seem to be producing.
ADKaster
force-pushed
the
bump-llvm-14-0-6
branch
from
70e611f to
6148b7d
Compare
ADKaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup-cpp was giving compiler binaries in the cached tool path that could not properly find native host toolchain headers on Ubuntu and macOS.
Change to rely on the pre-installed compilers rather than trying to get llvm using the third-party action, and use setup-ninja to make sure we have ninja installed. Because the setup-ninja action doesn't use an absolute path for its
core.addPath()call (whyyyyyyy) we have to make sure to root the initial cmake configuration in $GITHUB_WORKSPACE rather thanbuildPath.Succesful run using this: https://github.com/jntrnr/jaktnesmonster/actions/runs/3505500353/jobs/5871847368