Skip to content

Add rl-gsm8k group present in main #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danieltremblay
Copy link
Collaborator

@danieltremblay danieltremblay commented May 16, 2025

Description by Korbit AI

What change is being made?

Add a new dependency group rl-gsm8k with the version constraints for vllm in pyproject.toml.

Why are these changes being made?

This change is being made to introduce a new package configuration that includes the vllm module, allowing the project to utilize its functionalities when the rl-gsm8k feature is needed, ensuring that compatibility is maintained between versions 0.5.3 and 0.6.6.post1.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this owl.

 ,_,
(.,.)
(   )
-"-"---

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@danieltremblay danieltremblay requested review from ollmer and jpt-sn May 16, 2025 19:57
@danieltremblay danieltremblay force-pushed the webagent_updates_with_rl-gsm8k branch from 14a7fb5 to e467b32 Compare May 20, 2025 15:17
@danieltremblay
Copy link
Collaborator Author

Tests run at https://github.com/ServiceNow/TapeAgents/actions/runs/15140056857/job/42561448783?pr=226 - skipped test_gaia_agent(), others passed

Copy link
Collaborator

@jpt-sn jpt-sn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieltremblay danieltremblay merged commit bbeadb4 into webagent_updates_with_mcp May 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants