Skip to content

refactor: introduce strong types enforcing invariants #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 3, 2022

Conversation

Shadow53
Copy link
Owner

@Shadow53 Shadow53 commented Apr 3, 2022

Resolves #96.

Adds new types and tests representing different types of checksums, paths, and names, that enforce required invariants at parse/creation time.

@Shadow53 Shadow53 added the enhancement New feature or request label Apr 3, 2022
@Shadow53 Shadow53 added this to the 0.5.0 milestone Apr 3, 2022
@Shadow53 Shadow53 self-assigned this Apr 3, 2022
@netlify
Copy link

netlify bot commented Apr 3, 2022

Deploy Preview for hoard-docs ready!

Name Link
🔨 Latest commit 819e4de
🔍 Latest deploy log https://app.netlify.com/sites/hoard-docs/deploys/6249608602f334000802eb25
😎 Deploy Preview https://deploy-preview-109--hoard-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #109 (819e4de) into main (619601f) will increase coverage by 0.82%.
The diff coverage is 95.14%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   89.52%   90.34%   +0.82%     
==========================================
  Files          61       69       +8     
  Lines        4669     4932     +263     
==========================================
+ Hits         4180     4456     +276     
+ Misses        489      476      -13     
Impacted Files Coverage Δ
src/command/mod.rs 28.57% <0.00%> (ø)
src/config/builder/environment/mod.rs 100.00% <ø> (ø)
src/hoard/mod.rs 0.00% <ø> (ø)
src/hoard/pile_config.rs 100.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/checkers/history/operation/v1.rs 69.23% <52.38%> (+16.50%) ⬆️
tests/hoard_diff.rs 87.40% <84.00%> (+0.19%) ⬆️
src/command/diff.rs 71.92% <87.50%> (-0.49%) ⬇️
src/config/builder/envtrie.rs 82.83% <88.18%> (-6.71%) ⬇️
src/env_vars.rs 86.84% <88.46%> (+2.46%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619601f...819e4de. Read the comment docs.

@Shadow53 Shadow53 merged commit 1140b71 into main Apr 3, 2022
@Shadow53 Shadow53 deleted the 96-stronger-typing branch April 3, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce stronger typing
1 participant