Skip to content

refactor: reuse operation logs for backup/restore #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Shadow53
Copy link
Owner

@Shadow53 Shadow53 commented Apr 4, 2022

Resolves #107.

Previous code iterated over files twice, which invoked more I/O than necessary.

This creates a couple functions that return an iterator that can be used without invoking disk I/O.

@Shadow53 Shadow53 added the enhancement New feature or request label Apr 4, 2022
@Shadow53 Shadow53 added this to the 0.5.0 milestone Apr 4, 2022
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for hoard-docs ready!

Name Link
🔨 Latest commit acd9414
🔍 Latest deploy log https://app.netlify.com/sites/hoard-docs/deploys/624b87b5c0a91200098ed76e
😎 Deploy Preview https://deploy-preview-111--hoard-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #111 (acd9414) into main (1140b71) will decrease coverage by 0.11%.
The diff coverage is 87.82%.

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   90.49%   90.37%   -0.12%     
==========================================
  Files          69       69              
  Lines        4932     5027      +95     
==========================================
+ Hits         4463     4543      +80     
- Misses        469      484      +15     
Impacted Files Coverage Δ
src/hoard/iter/operation.rs 82.85% <50.00%> (ø)
src/checkers/history/operation/mod.rs 81.85% <65.00%> (-1.35%) ⬇️
src/command/backup_restore.rs 75.86% <90.90%> (+0.86%) ⬆️
src/hoard/mod.rs 66.66% <94.73%> (+66.66%) ⬆️
src/checkers/history/operation/v2.rs 94.75% <100.00%> (+1.08%) ⬆️
src/checkers/mod.rs 100.00% <100.00%> (ø)
src/checkers/history/last_paths.rs 93.27% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1140b71...acd9414. Read the comment docs.

@Shadow53 Shadow53 merged commit 13039f5 into main Apr 5, 2022
@Shadow53 Shadow53 deleted the 107-use-generated-operations-when-backing-up-restoring branch April 5, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use generated operations when backing up/restoring
1 participant