refactor!: optimize operations with multithreaded tokio #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying async to `hoard_edit.rs` caused tests to fail -- specifically, it hangs. It works still based on ad hoc testing, though.
✅ Deploy Preview for hoard-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 92.22% 91.42% -0.81%
==========================================
Files 74 71 -3
Lines 6176 6206 +30
==========================================
- Hits 5696 5674 -22
- Misses 480 532 +52
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17.
This change includes a few large optimizations to help Hoard run faster:
CachedHoardItem: processes a system/hoard file pair once and caches the results for later usagetokio: code was rewritten to use async/await with the multithreaded tokio runtimeNote: Windows now has to be tested in release mode.
This is most likely because of the giant
matchstatement insrc/hoard/iter/diff_files.rs. rust-lang/rust#34283 reports that, in debug mode, the stack usage of a match statement is the sum of all of the branches, while in release mode it is the amount of the largest branch only (if I understand right). Windows was experiencing stack overflows in CI, and this fixed it.