Skip to content

fix: fix operation version upgrades #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2022
Merged

fix: fix operation version upgrades #129

merged 4 commits into from
Apr 26, 2022

Conversation

Shadow53
Copy link
Owner

  • Created a shell script that creates operation log files using the released version of Hoard 0.4.0, then runs the upgrade command using the current tree.
    • Written in such a way to make it easy to expand to using 0.5.0 if 0.6.0 introduces changes, etc.
  • Fixed issues that came up as a result of running the script

Shadow53 added 3 commits April 25, 2022 15:47
@Shadow53
fix: add operation test script, fix errors
2376a51 
- Uses a manual expansion of the `serde::Deserialize` derive to provide
  warnings on why data did not match a specific variant.
- Script can be easily expanded with newer Hoard versions, as they are
  released.
@Shadow53
ci: add test script to CI
283a3d1
@Shadow53
test: fix test compile errors
dff147c
@Shadow53 Shadow53 added the enhancement New feature or request label Apr 26, 2022
@Shadow53 Shadow53 added this to the 0.5.0 milestone Apr 26, 2022
@netlify
Copy link

netlify bot commented Apr 26, 2022 •
edited
Loading

✅ Deploy Preview for hoard-docs ready!

Name Link
🔨 Latest commit d8c75d3
🔍 Latest deploy log https://app.netlify.com/sites/hoard-docs/deploys/62677a3128e62200089caf91
😎 Deploy Preview https://deploy-preview-129--hoard-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #129 (d8c75d3) into main (4a886c2) will decrease coverage by 0.14%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   91.54%   91.40%   -0.15%     
==========================================
  Files          71       71              
  Lines        6212     6246      +34     
==========================================
+ Hits         5687     5709      +22     
- Misses        525      537      +12
Impacted Files Coverage Δ
src/checkers/history/last_paths.rs 93.27% <ø> (-5.89%) ⬇️
src/checkers/history/operation/v2.rs 96.21% <ø> (ø)
src/checkers/history/operation/mod.rs 85.46% <81.48%> (-0.43%) ⬇️
src/checkers/history/operation/util.rs 99.38% <100.00%> (+0.02%) ⬆️
src/checkers/history/operation/v1.rs 100.00% <100.00%> (ø)
tests/hoard_upgrade.rs 98.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a886c2...d8c75d3. Read the comment docs.

@Shadow53 Shadow53 merged commit b15c369 into main Apr 26, 2022
@Shadow53 Shadow53 deleted the operation-fixes branch April 26, 2022 05:06
This was linked to issues Apr 26, 2022
Improve Operation error message(s) #123
Closed
Actually test that newer versions are compatible with older operation logs #124
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Actually test that newer versions are compatible with older operation logs Improve Operation error message(s)
1 participant
@Shadow53