Skip to content

refactor: log errors at creation site #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 11, 2022
Merged

refactor: log errors at creation site #133

merged 23 commits into from
May 11, 2022

Conversation

Shadow53
Copy link
Owner

Resolves #95.

The primary purpose of this branch is to make sure errors are reported at the creation site (or where they enter this crate's code).

There are a couple logic fixes that got applied too, though, as part of this,

@netlify
Copy link

netlify bot commented May 11, 2022

Deploy Preview for hoard-docs ready!

Name Link
🔨 Latest commit 3754b8f
🔍 Latest deploy log https://app.netlify.com/sites/hoard-docs/deploys/627b6195cfc371000903b603
😎 Deploy Preview https://deploy-preview-133--hoard-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Shadow53 Shadow53 added the bug Something isn't working label May 11, 2022
@Shadow53 Shadow53 added this to the 0.5.0 milestone May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #133 (69df08e) into main (4e63b69) will decrease coverage by 0.86%.
The diff coverage is 74.77%.

❗ Current head 69df08e differs from pull request most recent head 3754b8f. Consider uploading reports for the commit 3754b8f to get more accurate results

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   91.51%   90.65%   -0.87%     
==========================================
  Files          71       71              
  Lines        6246     5691     -555     
==========================================
- Hits         5716     5159     -557     
- Misses        530      532       +2     
Impacted Files Coverage Δ
src/command/edit.rs 0.00% <0.00%> (ø)
src/hoard/iter/all_files.rs 88.61% <26.92%> (-0.60%) ⬇️
src/config/builder/envtrie.rs 86.36% <60.00%> (+3.40%) ⬆️
src/hoard_item/cached.rs 77.00% <66.66%> (-1.58%) ⬇️
src/lib.rs 68.00% <66.66%> (-32.00%) ⬇️
src/hoard/iter/diff_files.rs 90.84% <68.18%> (-8.43%) ⬇️
src/checkers/history/operation/util.rs 91.91% <72.72%> (-7.47%) ⬇️
src/dirs/unix.rs 76.92% <72.72%> (-23.08%) ⬇️
src/config/builder/mod.rs 70.67% <75.00%> (-8.85%) ⬇️
src/config/mod.rs 80.85% <75.00%> (-6.43%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e63b69...3754b8f. Read the comment docs.

@Shadow53 Shadow53 merged commit 555a5af into main May 11, 2022
@Shadow53 Shadow53 deleted the 95-error-logging branch May 11, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure errors are reported at creation site
1 participant