This repository was archived by the owner on Mar 31, 2025. It is now read-only.
Fix Chart Saving in Linux and MacOS, Display App Icon in MacOS #16456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you know, even though mac is not properly supported, I feel like this should be done
|
hopefully this works, I'm still gonna test on my own system, compiling just takes forever! |
crowplexus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug with Linux and Mac where the files saved by the chart editor do not correspond to where they are actually saved on Windows (i.e: file named and saved as "assets\shared\data\test\test-hard.json" instead of "test-hard.json" in the "assets/shared/data/test" folder)
also fixes the app icon not showing up in the MacOS dock
SHOULD fix #16441