-
-
Notifications
You must be signed in to change notification settings - Fork 20
Dev/Feature - Future Feature Release #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShaneBeee
wants to merge
22
commits into
master
Choose a base branch
from
dev/feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng/unfreezing connections - will be more useful with dialogs when that is merged
…fiers by key - Ref #891
- we only support paper 1.21.4+ and this was added in Paper 1.20.4
- This prevents a lot of copy/pasting - Also included the MC version which these were generated
- Add McWiki link for more detailed info - Add usage to docs (not sure why I didn't do this before)
* Dialog - initial work on adding dialogs * actions - split up actions into 2 diff files * SecCallbackActionButton - add callback action button * SecCallbackActionButton - add an option to get uuid - also commit the event as I forgot that before * dialogs - fix patterns * dialogs.sk - add tests * SecCallbackActionButton - change description for NBT - Figured out what its for * Inputs - better handle errors when input key is invalid - Paper just throws a massive exception * EffOpenDialog - add option to close * SecCallbackActionButton - add event-values for player name and player connection * SecCallbackActionButton - fix typo * test/dialogs.sk - change test to actually run code to make sure to catch internal errors * SecDynamicCallbackActionButton - rename * SecDynamicRunCommandActionButton - add run command action button
- Change event to use Audience - Add event-values - Use SyntaxStringBuilder in toString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR outlines a future feature release.
Temp changelog:
ADDED:
FIXED:
INTERNAL:
Target Minecraft Versions: any
Requirements: none
Related Issues: none
Checklist before requesting a review