Skip to content

Fix lint issues related to comparisons with None #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Fix lint issues related to comparisons with None #1115

merged 1 commit into from
Jun 19, 2025

Conversation

yurivict
Copy link
Contributor

No description provided.

@yurivict yurivict mentioned this pull request Jun 12, 2025
Open
@MartinBubel
Copy link
Contributor

I assume that tests are failing because of pytest>=8.0.
I‘ll update the workflow and see if it succeeds then.

@yurivict
Copy link
Contributor Author

These are obviously legit fixes.
You can just merge this PR without waiting for tests.

@MartinBubel
Copy link
Contributor

Sure, no doubt about that.
But I won‘t merge a broken CI into devel.

I‘ll fix the CI in another issue and rebase your PR.

@MartinBubel MartinBubel merged commit 38bffb1 into SheffieldML:devel Jun 19, 2025
4 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurivict @MartinBubel