Allow VAPID sub to be an HTTPS URL #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC says: > The "sub" claim SHOULD include a contact URI for the application > server as either a "mailto:" (email) [RFC6068] or an "https:" > [RFC2818] URI. However the library assumes the passed in subscribed is always an e-mail address, without leaving a way to pass an HTTPS URL.
|
Gentle ping, any chance to get this reviewed? |
|
Did you have time to have a look at this, @SherClockHolmes? |
|
Gentle ping |
|
Hi @SherClockHolmes, any chance to get this reviewed? |
|
This is relevant to me as well :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC says:
However the library assumes the passed in subscribed is always an e-mail address, without leaving a way to pass an HTTPS URL.