Allow VAPID sub to be an HTTPS URL#57
Merged
SherClockHolmes merged 1 commit intoSherClockHolmes:masterfrom Jan 2, 2025
Merged
Conversation
Contributor
Author
|
Gentle ping, any chance to get this reviewed? |
Contributor
Author
|
Did you have time to have a look at this, @SherClockHolmes? |
Contributor
Author
|
Gentle ping |
Contributor
Author
|
Hi @SherClockHolmes, any chance to get this reviewed? |
|
This is relevant to me as well :-) |
Owner
The RFC says: > The "sub" claim SHOULD include a contact URI for the application > server as either a "mailto:" (email) [RFC6068] or an "https:" > [RFC2818] URI. However the library assumes the passed in subscribed is always an e-mail address, without leaving a way to pass an HTTPS URL.
emersion
force-pushed
the
subscriber-url
branch
from
66a3d8a to
846d2d8
Compare
Contributor
Author
|
Done! |
SherClockHolmes
approved these changes
Jan 2, 2025
Contributor
Author
|
Thank you! |
emersion
added a commit
to emersion/soju
that referenced
this pull request
Jan 2, 2025
This PR has been merged: SherClockHolmes/webpush-go#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC says:
However the library assumes the passed in subscribed is always an e-mail address, without leaving a way to pass an HTTPS URL.