Improve example robustness #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend expects the raw subscription, not one wrapped in an extra object. By printing it without the wrapper, we make it easier for users to do the right thing.
Added missing code block language.
When testing push notifications on the phone, the JS console isn't readily accessible. So in addition to printing to the console, print progress updates to the page itself.
Sanity check the parsed JSON by checking for the presence of the Endpoint, and not ignoring potential parse errors. Log errors. See SherClockHolmes#56 for an example of where this would have been useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying the example, I ran into a couple of issues, which I've addressed here: