-
Notifications
You must be signed in to change notification settings - Fork 191
use SQLITE_DATABASE
resource type, to permit larger file uploads
#6098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use SQLITE_DATABASE
resource type, to permit larger file uploads
#6098
Conversation
SQLITE_DATABASE
resource type for createStagedUpload
SQLITE_DATABASE
resource type, to permit files up to 10GB!
Coverage report
Test suite run success3037 tests passing in 1318 suites. Report generated by 🧪jest coverage report action from 2468e7c |
Sadly there is more to be done here methinks; when I run this command I get the above error. |
Sadly you're right :( I have no idea why though, I was pretty convinced this should work. It should just require And that is manually set to true for the CLI app: https://experiments.shopify.com/flags/bulk_data_transfer_public @rzaharenkov any idea why this isn't visible to the CLI? 🤔 |
ahh looks like this explains it! https://github.com/Shopify/workflows-operations/issues/3359#issuecomment-3070122460 |
f23e3c0
to
e1dc115
Compare
SQLITE_DATABASE
resource type, to permit files up to 10GB!SQLITE_DATABASE
resource type, to permit files up to 300MB
a92bd5f
to
bc3f5fb
Compare
SQLITE_DATABASE
resource type, to permit files up to 300MBSQLITE_DATABASE
resource type, to permit larger file uploads
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
3ff75e3
to
524454a
Compare
524454a
to
2468e7c
Compare
8dacb01
to
51c1ebb
Compare
WHY are these changes introduced?
Fixes https://github.com/Shopify/workflows-operations/issues/3359
WHAT is this pull request doing?
This PR updates the SQLite file upload functionality to:
SQLITE_DATABASE
resource type instead ofFILE
for staged uploadsHow to test your changes?
npm shopify store copy --from-file file_bigger_than_20_mb_smaller_than_300mb.sqlite --to-store target_store
with an sqlite file
Measuring impact
How do we know this change was effective? Please choose one:
Checklist