Use apropriate shop domain name in different environment#6123
Merged
Conversation
Closed
5 tasks
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3029 tests passing in 1311 suites. Report generated by 🧪jest coverage report action from 51b40da |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
odacrem
approved these changes
Jul 16, 2025
skelley-ton
approved these changes
Jul 17, 2025
5ef3c1d to
e94ed1a
Compare
4e6391e to
106c1bd
Compare
Merge activity
|
106c1bd to
51b40da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
To standardize store domain normalization by using the shared
normalizeStoreFqdnfunction from the CLI kit.WHAT is this pull request doing?
Replaces the custom
storeFullDomainutility function with the sharednormalizeStoreFqdnfunction from@shopify/cli-kit/node/context/fqdnacross store operations (copy, export, import). This ensures consistent handling of store domains throughout the codebase.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist