-
Notifications
You must be signed in to change notification settings - Fork 191
Use apropriate shop domain name in different environment #6123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success3029 tests passing in 1311 suites. Report generated by 🧪jest coverage report action from 51b40da |
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
5ef3c1d
to
e94ed1a
Compare
4e6391e
to
106c1bd
Compare
Merge activity
|
106c1bd
to
51b40da
Compare
WHY are these changes introduced?
To standardize store domain normalization by using the shared
normalizeStoreFqdn
function from the CLI kit.WHAT is this pull request doing?
Replaces the custom
storeFullDomain
utility function with the sharednormalizeStoreFqdn
function from@shopify/cli-kit/node/context/fqdn
across store operations (copy, export, import). This ensures consistent handling of store domains throughout the codebase.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist