Skip to content

Use apropriate shop domain name in different environment #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

rzaharenkov
Copy link
Contributor

@rzaharenkov rzaharenkov commented Jul 16, 2025

WHY are these changes introduced?

To standardize store domain normalization by using the shared normalizeStoreFqdn function from the CLI kit.

WHAT is this pull request doing?

Replaces the custom storeFullDomain utility function with the shared normalizeStoreFqdn function from @shopify/cli-kit/node/context/fqdn across store operations (copy, export, import). This ensures consistent handling of store domains throughout the codebase.

How to test your changes?

  1. Run store commands with both full domains and shop handles:
  shopify store copy --from-store=my-store
  shopify store copy --from-store=my-store.myshopify.com

  SHOPIFY_SERVICE_ENV=local shopify store copy --from-store=shop2
  SHOPIFY_SERVICE_ENV=local shopify store copy --from-store=shop2.my.shop.dev
  1. Verify all operations work correctly with both formats.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@odacrem odacrem mentioned this pull request Jul 16, 2025
Copy link
Contributor Author

rzaharenkov commented Jul 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rzaharenkov rzaharenkov marked this pull request as ready for review July 16, 2025 20:14
@rzaharenkov rzaharenkov requested review from a team as code owners July 16, 2025 20:14
Copy link
Contributor

github-actions bot commented Jul 16, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.06% (+0% 🔼)
12999/16653
🟡 Branches
72.28% (+0.02% 🔼)
6339/8770
🟡 Functions
78.17% (-0.01% 🔻)
3370/4311
🟡 Lines
78.46% (+0.01% 🔼)
12308/15686
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / info.ts
81.44%
61.19% (-1.49% 🔻)
90.32% 83.15%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

3029 tests passing in 1311 suites.

Report generated by 🧪jest coverage report action from 51b40da

Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@odacrem odacrem changed the base branch from ea-release to graphite-base/6123 July 17, 2025 13:24
@odacrem odacrem force-pushed the graphite-base/6123 branch from 5ef3c1d to e94ed1a Compare July 17, 2025 13:24
@odacrem odacrem force-pushed the rz-fix-domain-for-local-dev branch from 4e6391e to 106c1bd Compare July 17, 2025 13:24
@odacrem odacrem changed the base branch from graphite-base/6123 to main July 17, 2025 13:24
Copy link

graphite-app bot commented Jul 17, 2025

Merge activity

  • Jul 17, 2:04 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Jul 17, 2:04 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@odacrem odacrem force-pushed the rz-fix-domain-for-local-dev branch from 106c1bd to 51b40da Compare July 17, 2025 14:08
@odacrem odacrem added this pull request to the merge queue Jul 17, 2025
Merged via the queue into main with commit cedc213 Jul 17, 2025
50 of 54 checks passed
@odacrem odacrem deleted the rz-fix-domain-for-local-dev branch July 17, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants