Update https.Agent to leave keepAlive with the default value
#6130
+43
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3035 tests passing in 1316 suites. Report generated by 🧪jest coverage report action from ed77b95 |
|
🫰✨ Thanks @karreiro! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected]Tip If you get an Caution After installing, validate the version by running just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #6062
User logs suggest a pattern where the first request succeeds (across different endpoints), but the second request fails with "Client network socket disconnected before secure TLS connection was established".
This points to a possible issue with socket reuse. When
keepAliveis enabled, the first request's socket is saved for reuse, but by the time the second request tries to use it, the server may have already closed its side.There are a few factors that can lead to this issue: aggressive server timeouts, dns rotation, or network setups that don’t guarantee the same backend each time.
This PR adds basic diagnostics and leave
keepAlivewith the default value (false) — forcing a new TCP connection for each request. If this hypnotises gets validated, this configuration must be defined at theRequestModeInputlevel.