Show a nice error message if user is running node <20 #6138
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanVerasamy
force-pushed
the
require-node-at-least-20
branch
from
575d9b1 to
609892b
Compare
JordanVerasamy
force-pushed
the
require-node-at-least-20
branch
from
609892b to
faab565
Compare
skelley-ton
approved these changes
Jul 21, 2025
JordanVerasamy
force-pushed
the
require-node-at-least-20
branch
from
faab565 to
6c333a5
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success3046 tests passing in 1314 suites. Report generated by 🧪jest coverage report action from 6c333a5 |
isaacroldan
reviewed
Jul 22, 2025
| headline: 'Update to Node 20 or higher to run `shopify store copy`.', | ||
| body: [`The \`store copy\` command requires Node 20 or higher. Current Node version: ${nodeMajorVersion}.`], | ||
| }) | ||
| process.exit(1) |
There was a problem hiding this comment.
try to avoid using process.exit and instead throw an error, that will be tracked.
Also, in cli-kit we have the exitIfOldNodeVersion already. It's currently checking for node <18, but maybe we can upgrade it to <20
isaacroldan
requested changes
Jul 22, 2025
|
Great feedback thanks!! Will adjust :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
https://github.com/Shopify/workflows-operations/issues/3367
WHAT is this pull request doing?
Show a nice error if user is running node version <20.
How to test your changes?