Handle access denied file upload error #6139
Merged
+49
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes https://github.com/Shopify/workflows-operations/issues/3398
Adds error handling for
file_uploader
to handleACCESS_DENIED
errors for stagedUploadCreate. What the error looks like in prod:WHAT is this pull request doing?
Instead of the above, we'll now show this:

This PR makes it so that adding
bulk_data
permissions from admin will allow access of stagedUploadCreate for sqlite files for staff members of a shop that aren't shop owners.How to test your changes?
Get added to an EA shop but not as owner, make sure you don't have
bulk_data_import
orbulk_data_export
permissions. Then try running an import e.g.pnpm shopify store copy --from-file=test.sqlite --to-store=rusty-development-dev-3
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist